support rolling on jammy#494
Conversation
|
cc @SteveMacenski Could you review this PR? |
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
Sorry it took a bit, I was on vacation. I really appreciate the help to get this to 22.04 and the thoroughness. I think though we can just drop outdated support from this branch!
lib/karto_sdk/CMakeLists.txt
Outdated
| target_link_libraries(kartoSlamToolbox ${Boost_LIBRARIES} TBB::tbb) | ||
| else() | ||
| target_link_libraries(kartoSlamToolbox ${Boost_LIBRARIES} ${TBB_LIBRARIES}) | ||
| add_compile_definitions(USE_DEPRECATED_TBB_API) |
There was a problem hiding this comment.
Is USE_DEPRECATED_TBB_API for supporting 22.04's change of TBB? If so, you can just use the new APIs and don't need to support backwards. There are other branches for galactic/foxy/etc, this is for bleeding edge rolling so we can make API breaking changes here safely. Unless the old version is used in 22.04/Humble, we don't need to support it
There was a problem hiding this comment.
Yes. I missed the old distribution branches, so I removed backward support at ec110d3.
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
2 participants
Basic Info
Description of contribution in a few bullet points
This PR enables build on rolling distribution on Ubuntu22.04.
Description of documentation updates required from your changes
Future work that may be required in bullet points